linux-kernel - Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8144f711-b4fd-730c-4e9f-780c42d5e68f@users.sourceforge.net>
Date:   Mon, 15 Jan 2018 20:04:03 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Ladislav Michl <ladis@...ux-mips.org>, linux-omap@...r.kernel.org
Cc:     Lee Jones <lee.jones@...aro.org>, Tony Lindgren <tony@...mide.com>,
        Roger Quadros <rogerq@...com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: mfd/omap-usb-tll: Allocate driver data at once in
 usbtll_omap_probe()

>> So I hope that your solution approach will be also fine.
>> Will it supersede my proposal?
> 
> Who knows, perhaps it would be the best if you could judge yourself...

I am also curious on how other contributors will respond to
your following update suggestion.

> 8<--------
> 
> Subject: [PATCH] mfd/omap-usb-tll: Allocate driver data at once

Would it have been clearer to use this information as the subject
for this reply already?

Are you fine with that this change approach was recorded in
a possibly questionable format?
https://patchwork.kernel.org/patch/10165193/

> Allocating memory to store clk array together with driver
> data simplifies error unwinding and allows deleting memory
> allocation failure message as there is now only single point
> where allocation could fail.

* Will it matter to mention the previous software situation a bit
  in such a commit description?

* Would you like to add a tag “link”?

* Are you going to “supersede” any more source code adjustments
  around questionable error messages?

Regards,
Markus