linux-kernel - Re: [PATCH v2] fs: Add VirtualBox guest shared folder (vboxsf) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180115223644.GN13338@ZenIV.linux.org.uk>
Date:   Mon, 15 Jan 2018 22:36:45 +0000
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Thayer <michael.thayer@...cle.com>,
        Larry Finger <Larry.Finger@...inger.net>,
        Christoph Hellwig <hch@...radead.org>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v2] fs: Add VirtualBox guest shared folder (vboxsf)
 support

* what hch said about mount options.  Get rid of that before the thing
  goes into mainline.

* all "inode = GET_F_DENTRY(f)->d_inode;" are complete BS; it's called
  file_inode(f).  Kill GET_F_DENTRY() off and be done with that.

* your ->rename() can race with ->get_link().  Look at the place where
  the former reassigns ->path and frees the old value and think what
  happens if the latter is called just prior to that kfree().

* the same goes for sf_inode_revalidate() vs. rename().

* just what happens to ->path of inode when e.g. its grandparent
  directory is renamed?

* AFAICS, you consider all negative dentries invalid.  Why do you even
  hash them, then?