linux-kernel - Re: [PATCH v2] s390: fix handling of -1 in set{,fs}[gu]id16 syscalls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180115223652.GB3054@osiris>
Date:   Mon, 15 Jan 2018 23:36:52 +0100
From:   Heiko Carstens <heiko.carstens@...ibm.com>
To:     Eugene Syromiatnikov <esyr@...hat.com>
Cc:     linux-s390@...r.kernel.org,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] s390: fix handling of -1 in set{,fs}[gu]id16 syscalls

On Mon, Jan 15, 2018 at 08:38:17PM +0100, Eugene Syromiatnikov wrote:
> For some reason, the implementation of some 16-bit ID system calls
> (namely, setuid16/setgid16 and setfsuid16/setfsgid16) used type cast
> instead of low2highgid/low2highuid macros for converting [GU]IDs, which
> led to incorrect handling of value of -1 (which ought to be considered
> invalid).
> 
> Discovered by strace test suite.
> 
> Cc: stable@...r.kernel.org
> Signed-off-by: Eugene Syromiatnikov <esyr@...hat.com>
> ---
>  arch/s390/kernel/compat_linux.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied, thanks!