linux-kernel - Re: [PATCH] sound/pci/hda: depends on instead of select for INPUT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h1siref2e.wl-tiwai@suse.de>
Date:   Mon, 15 Jan 2018 08:50:17 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Randy Dunlap" <rdunlap@...radead.org>
Cc:     "moderated for non-subscribers" <alsa-devel@...a-project.org>,
        "LKML" <linux-kernel@...r.kernel.org>,
        "Jaroslav Kysela" <perex@...ex.cz>
Subject: Re: [PATCH] sound/pci/hda: depends on instead of select for INPUT

On Mon, 15 Jan 2018 06:11:56 +0100,
Randy Dunlap wrote:
> 
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Drivers should not 'select' a subsystem. Instead they should depend
> on it. If the subsystem is disabled, the user probably did that for
> a purpose and one driver shouldn't be changing that.
> 
> This also makes all sound/ drivers consistent w.r.t depending on INPUT
> instead of selecting it.
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Jaroslav Kysela <perex@...ex.cz>
> Cc: Takashi Iwai <tiwai@...e.com>
> Cc: alsa-devel@...a-project.org (moderated for non-subscribers)
> ---
>  sound/pci/hda/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- lnx-415-rc8.orig/sound/pci/hda/Kconfig
> +++ lnx-415-rc8/sound/pci/hda/Kconfig
> @@ -87,8 +87,8 @@ config SND_HDA_PATCH_LOADER
>  
>  config SND_HDA_CODEC_REALTEK
>  	tristate "Build Realtek HD-audio codec support"
> +	depends on INPUT
>  	select SND_HDA_GENERIC
> -	select INPUT

This would break if INPUT=m and SND_HDA_CODEC_REALTEK=y.
Usually, we take a trick like

	depends on INPUT=y || INPUT=SND_HDA_CODEC_REALTEK

But, looking at the change that introduced the dependency (commit
33f4acd3b214), the code doesn't necessarily depend on INPUT at all.
The select above was put there just because the random build with
INPUT=m and SND_HDA_CODEC_REALTEK=y would break otherwise.

The right fix in this case would be to replace IS_ENABLE(INPUT) with
IS_REACHABLE(INPUT) instead.


thanks,

Takashi