linux-kernel - [PATCH] sound/pci/hda: depends on instead of select for INPUT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <254bab8e-5629-0dc0-5a4e-9a010abf9ad8@infradead.org>
Date:   Sun, 14 Jan 2018 21:11:56 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     moderated for non-subscribers <alsa-devel@...a-project.org>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     Takashi Iwai <tiwai@...e.com>, Jaroslav Kysela <perex@...ex.cz>
Subject: [PATCH] sound/pci/hda: depends on instead of select for INPUT

From: Randy Dunlap <rdunlap@...radead.org>

Drivers should not 'select' a subsystem. Instead they should depend
on it. If the subsystem is disabled, the user probably did that for
a purpose and one driver shouldn't be changing that.

This also makes all sound/ drivers consistent w.r.t depending on INPUT
instead of selecting it.

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Jaroslav Kysela <perex@...ex.cz>
Cc: Takashi Iwai <tiwai@...e.com>
Cc: alsa-devel@...a-project.org (moderated for non-subscribers)
---
 sound/pci/hda/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- lnx-415-rc8.orig/sound/pci/hda/Kconfig
+++ lnx-415-rc8/sound/pci/hda/Kconfig
@@ -87,8 +87,8 @@ config SND_HDA_PATCH_LOADER
 
 config SND_HDA_CODEC_REALTEK
 	tristate "Build Realtek HD-audio codec support"
+	depends on INPUT
 	select SND_HDA_GENERIC
-	select INPUT
 	help
 	  Say Y or M here to include Realtek HD-audio codec support in
 	  snd-hda-intel driver, such as ALC880.