linux-kernel - Re: [02/12] watchdog: sp5100_tco: Fix watchdog disable bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1516131289.18904.6.camel@redhat.com>
Date:   Tue, 16 Jan 2018 14:34:49 -0500
From:   Lyude Paul <lyude@...hat.com>
To:     Guenter Roeck <linux@...ck-us.net>,
        Wim Van Sebroeck <wim@...ana.be>
Cc:     linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
        Zoltán Böszörményi <zboszor@...hu>
Subject: Re: [02/12] watchdog: sp5100_tco: Fix watchdog disable bit

On Sun, 2017-12-24 at 13:03 -0800, Guenter Roeck wrote:
> According to all published information, the watchdog disable bit for SB800
> compatible controllers is bit 1 of PM register 0x48, not bit 2. For the
> most part that doesn't matter in practice, since the bit has to be cleared
> to enable watchdog address decoding, which is the default setting, but it
> still needs to be fixed.
Reviewed-by: Lyude Paul <lyude@...hat.com>

> 
> Cc: Zoltán Böszörményi <zboszor@...hu>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
>  drivers/watchdog/sp5100_tco.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/sp5100_tco.h b/drivers/watchdog/sp5100_tco.h
> index f495fe03887a..2622cfe23dc1 100644
> --- a/drivers/watchdog/sp5100_tco.h
> +++ b/drivers/watchdog/sp5100_tco.h
> @@ -52,7 +52,7 @@
>  #define SB800_PM_WATCHDOG_CONFIG	0x4C
>  
>  #define SB800_PCI_WATCHDOG_DECODE_EN	(1 << 0)
> -#define SB800_PM_WATCHDOG_DISABLE	(1 << 2)
> +#define SB800_PM_WATCHDOG_DISABLE	(1 << 1)
>  #define SB800_PM_WATCHDOG_SECOND_RES	(3 << 0)
>  #define SB800_ACPI_MMIO_DECODE_EN	(1 << 0)
>  #define SB800_ACPI_MMIO_SEL		(1 << 1)
-- 
Cheers,
	Lyude Paul