linux-kernel - Re: [PATCH] powerpc/pseries: include linux/types.h in asm/hvcall.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wp0ia3x1.fsf@concordia.ellerman.id.au>
Date:   Tue, 16 Jan 2018 14:16:58 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Michal Suchanek <msuchanek@...e.de>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Cédric Le Goater <clg@...d.org>,
        David Gibson <david@...son.dropbear.id.au>,
        Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>,
        Michal Suchanek <msuchanek@...e.de>,
        "Tobin C. Harding" <me@...in.cc>,
        Michael Neuling <mikey@...ling.org>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc/pseries: include linux/types.h in asm/hvcall.h

Michal Suchanek <msuchanek@...e.de> writes:

> Commit 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
> settings") uses u64 in asm/hvcall.h without including linux/types.h
>
> This breaks hvcall.h users that do not include the header themselves.
>
> Fixes: 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
>     settings")
>
> Signed-off-by: Michal Suchanek <msuchanek@...e.de>
> ---
>  arch/powerpc/include/asm/hvcall.h | 1 +
>  1 file changed, 1 insertion(+)

Thanks. None of my ~250 defconfig test builds hit this, what config are
you using?

cheers

> diff --git a/arch/powerpc/include/asm/hvcall.h b/arch/powerpc/include/asm/hvcall.h
> index f0461618bf7b..eca3f9c68907 100644
> --- a/arch/powerpc/include/asm/hvcall.h
> +++ b/arch/powerpc/include/asm/hvcall.h
> @@ -353,6 +353,7 @@
>  #define PROC_TABLE_GTSE		0x01
>  
>  #ifndef __ASSEMBLY__
> +#include <linux/types.h>
>  
>  /**
>   * plpar_hcall_norets: - Make a pseries hypervisor call with no return arguments
> -- 
> 2.13.6