linux-kernel - Re: [PATCH] powerpc/pseries: include linux/types.h in asm/hvcall.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180116045347.GC30352@umbus.fritz.box>
Date:   Tue, 16 Jan 2018 15:53:47 +1100
From:   David Gibson <david@...son.dropbear.id.au>
To:     Michael Ellerman <mpe@...erman.id.au>
Cc:     Michal Suchanek <msuchanek@...e.de>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Cédric Le Goater <clg@...d.org>,
        Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>,
        "Tobin C. Harding" <me@...in.cc>,
        Michael Neuling <mikey@...ling.org>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc/pseries: include linux/types.h in asm/hvcall.h

On Tue, Jan 16, 2018 at 02:16:58PM +1100, Michael Ellerman wrote:
> Michal Suchanek <msuchanek@...e.de> writes:
> 
> > Commit 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
> > settings") uses u64 in asm/hvcall.h without including linux/types.h
> >
> > This breaks hvcall.h users that do not include the header themselves.
> >
> > Fixes: 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
> >     settings")
> >
> > Signed-off-by: Michal Suchanek <msuchanek@...e.de>
> > ---
> >  arch/powerpc/include/asm/hvcall.h | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Thanks. None of my ~250 defconfig test builds hit this, what config are
> you using?

I also hit this, but only when I backported the change to RH's 3.10
kernel.  I assumed something since then had added an indirect include.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)