linux-kernel - Re: [PATCH] ARM: davinci_all_defconfig: set CONFIG_DAVINCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHCN7xLwpLJPOe27sfKKbsSq3C75ZVtV9B0hpp3KDtAnxpc1mA@mail.gmail.com>
Date:   Tue, 16 Jan 2018 06:17:14 -0600
From:   Adam Ford <aford173@...il.com>
To:     Sekhar Nori <nsekhar@...com>
Cc:     David Lechner <david@...hnology.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: davinci_all_defconfig: set CONFIG_DAVINCI_WATCHDOG=y

On Mon, Jan 15, 2018 at 11:59 PM, Sekhar Nori <nsekhar@...com> wrote:
> On Monday 15 January 2018 10:59 PM, David Lechner wrote:
>> This changes CONFIG_DAVINCI_WATCHDOG from a module to a compiled-in
>> option. Since the reset function has been moved out of the mach code in
>> commit 0808d3260456 ("ARM: davinci: remove watchdog reset") and into the
>> watchdog driver, devices cannot reboot unless the watchdog driver is
>> loaded, so make it a compiled-in option so that we can always reboot, even
>> when modules are not loaded.
>>
>> Cc: Sekhar Nori <nsekhar@...com>
>> Suggested-by: Adam Ford <aford173@...il.com>
>> Signed-off-by: David Lechner <david@...hnology.com>
>
> Hmm, we already depend on modules to load correctly for a lot of
> functionality. Why should reboot be an exception? In general, unless the
> driver is needed for loading rootfile system, I would keep it as a module.

I would argue that his patch corrects a regression introduced by the
patch series.  Before the series, 'reboot' worked properly without the
watchdog being loaded as a module.  With this patch series 'reboot'
stops functioning which I would argue is a regression.  Making the
watchdog part of the kernel fixes the broken reboot regression.  I
would request it be accepted.

>
> Thanks,
> Sekhar

adam