linux-kernel - Re: [PATCH] [RESEND] gpu: ipu-v3: prg: avoid possible array underflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1516114934.9022.10.camel@pengutronix.de>
Date:   Tue, 16 Jan 2018 16:02:14 +0100
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Lucas Stach <l.stach@...gutronix.de>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RESEND] gpu: ipu-v3: prg: avoid possible array
 underflow

Hi Arnd,

On Tue, 2018-01-16 at 15:31 +0100, Arnd Bergmann wrote:
> gcc-8 reports that we access an array with a negative index
> in an error case:
> 
> drivers/gpu/ipu-v3/ipu-prg.c: In function 'ipu_prg_channel_disable':
> drivers/gpu/ipu-v3/ipu-prg.c:252:43: error: array subscript -22 is below array bounds of 'struct ipu_prg_channel[3]' [-Werror=array-bounds]
> 
> This moves the range check in front of the dereference.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ----
> Originally sent on Dec 4, 2017. No reply, so resending unchanged.

Thank you, applied to imx-drm/fixes.

regards
Philipp