linux-kernel - Re: [PATCH] iommu/vt-d: use domain instead of cache fetching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180117134606.duf22tresqonahmt@8bytes.org>
Date:   Wed, 17 Jan 2018 14:46:07 +0100
From:   Joerg Roedel <joro@...tes.org>
To:     Peter Xu <peterx@...hat.com>
Cc:     iommu@...ts.linux-foundation.org,
        Alex Williamson <alex.williamson@...hat.com>,
        dwmw2@...radead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/vt-d: use domain instead of cache fetching

On Wed, Jan 10, 2018 at 01:51:37PM +0800, Peter Xu wrote:
> after commit a1ddcbe93010 ("iommu/vt-d: Pass dmar_domain directly into
> iommu_flush_iotlb_psi", 2015-08-12), we have domain pointer as parameter
> to iommu_flush_iotlb_psi(), so no need to fetch it from cache again.
> 
> More importantly, a NULL reference pointer bug is reported on RHEL7 (and
> it can be reproduced on some old upstream kernels too, e.g., v4.13) by
> unplugging an 40g nic from a VM (hard to test unplug on real host, but
> it should be the same):
> 
[...]
> 
> CC: Alex Williamson <alex.williamson@...hat.com>
> Signed-off-by: Peter Xu <peterx@...hat.com>
> ---
>  drivers/iommu/intel-iommu.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied, thanks.