linux-kernel - Re: [PATCH V5 1/8] perf/x86/intel/uncore: customized event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1801181036210.1847@nanos>
Date:   Thu, 18 Jan 2018 10:36:42 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Kan Liang <kan.liang@...el.com>
cc:     mingo@...hat.com, peterz@...radead.org,
        linux-kernel@...r.kernel.org, acme@...nel.org, eranian@...gle.com,
        ak@...ux.intel.com
Subject: Re: [PATCH V5 1/8] perf/x86/intel/uncore: customized event_read for
 client IMC uncore

On Mon, 15 Jan 2018, kan.liang@...el.com wrote:

> From: Kan Liang <Kan.liang@...el.com>
> 
> There are two free running counters for client IMC uncore. The custom
> event_init() function hardcode their index to 'UNCORE_PMC_IDX_FIXED' and
> 'UNCORE_PMC_IDX_FIXED + 1'. To support the 'UNCORE_PMC_IDX_FIXED + 1'
> case, the generic uncore_perf_event_update is obscurely hacked.
> The code quality issue will bring problem when new counter index is
> introduced into generic code. For example, free running counter index.
> 
> Introduce customized event_read function for client IMC uncore.
> The customized function is exactly copied from previous generic
> uncore_pmu_event_read.
> The 'UNCORE_PMC_IDX_FIXED + 1' case will be isolated for client IMC
> uncore only.
> 
> Signed-off-by: Kan Liang <Kan.liang@...el.com>

Reviewed-by: Thomas Gleixner <tglx@...utronix.de>