linux-kernel - Re: [PATCH] PCI: dwc: dra7xx: add back CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180118183546.GA8492@e107981-ln.cambridge.arm.com>
Date:   Thu, 18 Jan 2018 18:36:00 +0000
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Niklas Cassel <niklas.cassel@...s.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Jingoo Han <jingoohan1@...il.com>,
        Peter Robinson <pbrobinson@...il.com>,
        linux-pci <linux-pci@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PCI: dwc: dra7xx: add back CONFIG_PCI dependency for
 endpoint

On Thu, Jan 18, 2018 at 05:39:02PM +0100, Arnd Bergmann wrote:

[...]

> > However, since pci_irqd_intx_xlate is only defined inside
> > CONFIG_PCI, even 489f8fe6aa71 will not help.
> >
> > Not completely sure about this, but perhaps a better fix is:
> >
> > +++ b/include/linux/pci.h
> > @@ -1686,6 +1686,12 @@ static inline int pci_get_new_domain_nr(void) { return -ENOSYS; }
> >  #define dev_is_pf(d) (false)
> >  static inline bool pci_acs_enabled(struct pci_dev *pdev, u16 acs_flags)
> >  { return false; }
> > +static inline int pci_irqd_intx_xlate(struct irq_domain *d,
> > +                                     struct device_node *node,
> > +                                     const u32 *intspec,
> > +                                     unsigned int intsize,
> > +                                     unsigned long *out_hwirq,
> > +                                     unsigned int *out_type) { return 0; }
> >  #endif /* CONFIG_PCI */
> >
> >  /* Include architecture-dependent settings and functions */
> >
> >
> > And a 'Fixes:' tag that references 524d59f6e30a
> 
> Looks fine to me, but I'd put the '{ return 0; }' in a new line for consistency
> with the other functions here, and maybe return -EINVAL instead of
> zero.
> 
> Can you submit that as a proper patch and add my
> 
> Acked-by: Arnd Bergmann <arnd@...db.de>

You can add my:

Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@....com>

too but I am a bit dubious about the Fixes: tag (it will be merged via
a separate branch and I do not think we really need it), I would omit it.

Please send it as soon as possible or I can do it, please let me
know.

Thanks,
Lorenzo