linux-kernel - Re: [RFC 0/4] tools lib traceevent: Install fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180119103713.GB20115@krava>
Date:   Fri, 19 Jan 2018 11:37:13 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Namhyung Kim <namhyung@...nel.org>, Jiri Olsa <jolsa@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        David Ahern <dsahern@...il.com>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [RFC 0/4] tools lib traceevent: Install fixes

On Tue, Aug 02, 2016 at 09:48:23AM -0400, Steven Rostedt wrote:
> On Tue, 2 Aug 2016 11:31:34 +0200
> Jiri Olsa <jolsa@...hat.com> wrote:
> 
> > On Tue, Aug 02, 2016 at 12:10:55PM +0900, Namhyung Kim wrote:
> > > On Mon, Aug 01, 2016 at 07:41:28PM +0200, Jiri Olsa wrote:  
> > > > hi,
> > > > sending traceevent changes to make this lib installable
> > > > under rpm spec.
> > > > 
> > > > Basically adding support to:
> > > >   - install header files
> > > >   - install version links
> > > > 
> > > > Having this patchset applied over the fedora source,
> > > > I could built following rpms:
> > > > 
> > > >   kernel-tools-libs
> > > >   kernel-tools-libs-devel
> > > > 
> > > > with added libtraceevent stuff:
> > > > 
> > > >   $ rpm -ql kernel-tools-libs
> > > >   /usr/lib64/libcpupower.so.0
> > > >   /usr/lib64/libcpupower.so.0.0.0
> > > >   /usr/lib64/libtraceevent.so.1
> > > >   /usr/lib64/libtraceevent.so.1.1.0
> > > > 
> > > >   $ rpm -ql kernel-tools-libs-devel
> > > >   /usr/include/cpufreq.h
> > > >   /usr/include/traceevent
> > > >   /usr/include/traceevent/event-parse.h
> > > >   /usr/include/traceevent/event-utils.h
> > > >   /usr/include/traceevent/kbuffer.h
> > > >   /usr/lib64/libcpupower.so
> > > >   /usr/lib64/libtraceevent.a
> > > >   /usr/lib64/libtraceevent.so
> > > > 
> > > > and could build following ex.c outside the kernel tree:
> > > > 
> > > >   $ cat ex.c 
> > > >   #include <traceevent/event-parse.h>
> > > > 
> > > >   int main(void)
> > > >   {
> > > >           struct pevent *pevent = pevent_alloc();
> > > >           printf("krava %p\n", pevent);
> > > >           return 0;
> > > >   }
> > > >   $ gcc -o ex ex.c -ltraceevent -ldl
> > > >   $ ./ex
> > > >   krava 0x10c6010
> > > >   $  
> > > 
> > > On my system, building ex.c with libtraceevent failed:
> > > 
> > > $ gcc -I ~/.local/include/ ex.c -L ~/.local/lib64 -ltraceevent -ldl
> > > /home/namhyung/.local/lib64/libtraceevent.so: undefined reference to `str_error_r'
> > > collect2: error: ld returned 1 exit status
> > > 
> > > 
> > > Also I think it'd be better for libtraceevent has dependency to libdl
> > > explicitly so that we can get rid of -ldl at the end.  
> > 
> > agreed, I'll queue your patch if v2 is needed
> > 
> 
> BTW, before we start making this ready for their own libraries, I'd
> like to make some changes with the naming convention. Mainly with
> event_format and format_field.
> 
> Perhaps we should change them to pevent_event and pevent_field?

hi,
I checked on this one and was surprised last email is from 2016 ;-)
so we did not move much with this.. is there still will to do that?

I think we were kind of waiting for the namespace changes in
traceevent library.. like to have some common prefix for public
functions/struct, like 'traceevent_' ?

thoughts? thanks,
jirka