linux-kernel - Re: [PATCH] drm/amdkfd: Use ARRAY_SIZE macro in kfd_build_sysfs_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fea2528-11a5-0210-6350-e916ebfebbdf@amd.com>
Date:   Fri, 19 Jan 2018 17:18:23 -0500
From:   Felix Kuehling <felix.kuehling@....com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>,
        Oded Gabbay <oded.gabbay@...il.com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        David Airlie <airlied@...ux.ie>
Cc:     amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amdkfd: Use ARRAY_SIZE macro in
 kfd_build_sysfs_node_entry

Looks good. This change is Reviewed-by: Felix Kuehling
<Felix.Kuehling@....com>

Regards,
  Felix


On 2018-01-18 07:39 PM, Gustavo A. R. Silva wrote:
> Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> index c6a7609..7783250 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> @@ -677,7 +677,7 @@ static int kfd_build_sysfs_node_entry(struct kfd_topology_device *dev,
>  	}
>  
>  	/* All hardware blocks have the same number of attributes. */
> -	num_attrs = sizeof(perf_attr_iommu)/sizeof(struct kfd_perf_attr);
> +	num_attrs = ARRAY_SIZE(perf_attr_iommu);
>  	list_for_each_entry(perf, &dev->perf_props, list) {
>  		perf->attr_group = kzalloc(sizeof(struct kfd_perf_attr)
>  			* num_attrs + sizeof(struct attribute_group),