linux-kernel - Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cca7e942-634d-f1ad-e42b-5b1d2ba5a868@iogearbox.net>
Date:   Fri, 19 Jan 2018 23:19:44 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Quentin Monnet <quentin.monnet@...ronome.com>,
        Roman Gushchin <guro@...com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-team@...com, Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Alexei Starovoitov <ast@...nel.org>
Subject: Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE
 programs

On 01/19/2018 03:37 PM, Quentin Monnet wrote:
> 2018-01-19 14:17 UTC+0000 ~ Roman Gushchin <guro@...com>
>> On Mon, Jan 15, 2018 at 07:32:01PM +0000, Quentin Monnet wrote:
> 
> [...]
> 
>>> Looks good, thanks Roman!
>>> Would you mind updating the map names as well? It seems the
>>> BPF_MAP_TYPE_CPUMAP is missing from the list in map.c.
>>
>> Hello, Quentin!
>>
>>
>> Here is the patch.
>>
>>
>> Thanks!
>>
>> --
>>
>> From 16245383a894038a63cc1ad4b77629ba704aaa38 Mon Sep 17 00:00:00 2001
>> From: Roman Gushchin <guro@...com>
>> Date: Fri, 19 Jan 2018 14:07:38 +0000
>> Subject: [PATCH bpf-next] bpftool: recognize BPF_MAP_TYPE_CPUMAP maps
>>
>> Add BPF_MAP_TYPE_CPUMAP map type to the list
>> of map type recognized by bpftool and define
>> corresponding text representation.
>>
>> Signed-off-by: Roman Gushchin <guro@...com>
>> Cc: Quentin Monnet <quentin.monnet@...ronome.com>
>> Cc: Jakub Kicinski <jakub.kicinski@...ronome.com>
>> Cc: Daniel Borkmann <daniel@...earbox.net>
>> Cc: Alexei Starovoitov <ast@...nel.org>
>> ---
>>  tools/bpf/bpftool/map.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c
>> index a152c1a5c94c..f95fa67bb498 100644
>> --- a/tools/bpf/bpftool/map.c
>> +++ b/tools/bpf/bpftool/map.c
>> @@ -66,6 +66,7 @@ static const char * const map_type_name[] = {
>>  	[BPF_MAP_TYPE_HASH_OF_MAPS]	= "hash_of_maps",
>>  	[BPF_MAP_TYPE_DEVMAP]		= "devmap",
>>  	[BPF_MAP_TYPE_SOCKMAP]		= "sockmap",
>> +	[BPF_MAP_TYPE_CPUMAP]		= "cpumap",
>>  };
>>  
>>  static unsigned int get_possible_cpus(void)
>>
> 
> Good, thank you!
> 
> Acked-by: Quentin Monnet <quentin.monnet@...ronome.com>

Applied to bpf-next, thanks for following up Roman!