linux-kernel - Re: [PATCH] iio/adc: depend on SYSFS instead of selecting it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180121123440.4c03c4f6@archlinux>
Date:   Sun, 21 Jan 2018 12:34:40 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-iio@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>
Subject: Re: [PATCH] iio/adc: depend on SYSFS instead of selecting it

On Sun, 14 Jan 2018 21:11:05 -0800
Randy Dunlap <rdunlap@...radead.org> wrote:

> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Drivers should not 'select' a subsystem. Instead they should depend
> on it. If the subsystem is disabled, the user probably did that for
> a purpose and one driver shouldn't be changing that.
> 
> This also makes all IIO drivers consistent w.r.t depending on SYSFS
> instead of selecting it.
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Jonathan Cameron <jic23@...nel.org>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Whilst thinking on the autobuilders, I'd love to relax the constraint
that this depends on the at91 subarch and at least allow build testing.
Will greatly improve our test coverage.

Maxime, I ran a quick test and it's fine on x86_64 anyway.  Do you know of
any reason we will get build problems on other platforms?

Thanks,

Jonathan

> Cc: linux-iio@...r.kernel.org
> ---
>  drivers/iio/adc/Kconfig |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- lnx-415-rc8.orig/drivers/iio/adc/Kconfig
> +++ lnx-415-rc8/drivers/iio/adc/Kconfig
> @@ -144,10 +144,9 @@ config ASPEED_ADC
>  config AT91_ADC
>  	tristate "Atmel AT91 ADC"
>  	depends on ARCH_AT91
> -	depends on INPUT
> +	depends on INPUT && SYSFS
>  	select IIO_BUFFER
>  	select IIO_TRIGGERED_BUFFER
> -	select SYSFS
>  	help
>  	  Say yes here to build support for Atmel AT91 ADC.
>