linux-kernel - Re: [PATCH v11 2/9] PCI: Remove unused __weak attribute in pci_register_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6816e715-df0f-ddff-d19d-de2d0f3101c7@huawei.com>
Date:   Mon, 22 Jan 2018 11:59:20 +0000
From:   John Garry <john.garry@...wei.com>
To:     <bhelgaas@...gle.com>
CC:     <mika.westerberg@...ux.intel.com>, <rafael@...nel.org>,
        <lorenzo.pieralisi@....com>, <rjw@...ysocki.net>,
        <robh+dt@...nel.org>, <arnd@...db.de>, <mark.rutland@....com>,
        <olof@...om.net>, <hanjun.guo@...aro.org>,
        <dann.frazier@...onical.com>, <benh@...nel.crashing.org>,
        <linux-kernel@...r.kernel.org>, <linux-acpi@...r.kernel.org>,
        <linuxarm@...wei.com>, <linux-pci@...r.kernel.org>,
        <minyard@....org>, <devicetree@...r.kernel.org>,
        <linux-arch@...r.kernel.org>
Subject: Re: [PATCH v11 2/9] PCI: Remove unused __weak attribute in
 pci_register_io_range()

On 21/01/2018 12:27, John Garry wrote:
> From: Gabriele Paoloni <gabriele.paoloni@...wei.com>
>
> Currently pci_register_io_range() has only one definition;
> therefore there is no use of the __weak attribute.
>
> Signed-off-by: Gabriele Paoloni <gabriele.paoloni@...wei.com>
> Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>
> ---

Hi Bjorn,

So I will need to respin this series again (and it still requires many 
more SOB tags), so do you want to pick up this minor patch in isolation 
now? It would save me carrying it, and save people receiving it in future.

Thanks,
John

>  drivers/pci/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 764ca7b..d8357ff 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -3383,7 +3383,7 @@ struct io_range {
>   * Record the PCI IO range (expressed as CPU physical address + size).
>   * Return a negative value if an error has occured, zero otherwise
>   */
> -int __weak pci_register_io_range(phys_addr_t addr, resource_size_t size)
> +int pci_register_io_range(phys_addr_t addr, resource_size_t size)
>  {
>  	int err = 0;
>
>