linux-kernel - Re: [PATCH v11 6/9] LPC: Support the LPC host on Hip06/Hip07 with DT bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c5766ef-3865-4125-dda9-3e0aaad90dca@huawei.com>
Date:   Mon, 22 Jan 2018 10:13:23 +0000
From:   John Garry <john.garry@...wei.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        <mika.westerberg@...ux.intel.com>, <rafael@...nel.org>,
        <lorenzo.pieralisi@....com>, <rjw@...ysocki.net>,
        <robh+dt@...nel.org>, <bhelgaas@...gle.com>, <arnd@...db.de>,
        <mark.rutland@....com>, <olof@...om.net>, <hanjun.guo@...aro.org>,
        <dann.frazier@...onical.com>
CC:     <benh@...nel.crashing.org>, <linux-kernel@...r.kernel.org>,
        <linux-acpi@...r.kernel.org>, <linuxarm@...wei.com>,
        <linux-pci@...r.kernel.org>, <minyard@....org>,
        <devicetree@...r.kernel.org>, <linux-arch@...r.kernel.org>
Subject: Re: [PATCH v11 6/9] LPC: Support the LPC host on Hip06/Hip07 with DT
 bindings

On 21/01/2018 17:54, Randy Dunlap wrote:
> On 01/21/2018 04:27 AM, John Garry wrote:
>> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
>> index 57e011d..91debe4 100644
>> --- a/drivers/bus/Kconfig
>> +++ b/drivers/bus/Kconfig
>> @@ -65,6 +65,14 @@ config BRCMSTB_GISB_ARB
>>  	  arbiter. This driver provides timeout and target abort error handling
>>  	  and internal bus master decoding.
>>
>> +config HISILICON_LPC
>> +	bool "Support for ISA I/O space on Hisilicon hip06/7"
>> +	depends on (ARM64 && (ARCH_HISI || COMPILE_TEST))
>> +	select INDIRECT_PIO
>> +	help
>> +	  Driver needed for some legacy ISA devices attached to Low-Pin-Count
>> +	  on Hisilicon hip06/7 SoC.
>
> Hi,
> Why is this config symbol bool instead of tristate?
>
> thanks,

Hi Randy,

Considering the nature of this driver, and the fact that it provides an 
IO space region through the logical PIO framework introduced, it does 
not make sense to have it as a loadable module.

A specific issue is that one of our boards uses this host for the UART 
console (through 8250-compatible device in BMC), so would want it in the 
kernel image.

I will add a note in the commit message and maybe config description 
explaining this.

Thanks,
John

>