linux-kernel - Re: [PATCH 1/2] Input: sur40: Delete an error message for a failed memory allocation in sur40

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dee45f67-7cf6-1b51-9735-4cfc5c68d610@posteo.de>
Date:   Mon, 22 Jan 2018 08:00:24 +0100
From:   Martin Kepplinger <martink@...teo.de>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        linux-input@...r.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Florian Echtler <floe@...terbrot.org>,
        Johan Hovold <johan@...nel.org>,
        Martin Kaltenbrunner <modin@...i.at>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/2] Input: sur40: Delete an error message for a failed
 memory allocation in sur40_probe()

On 2018-01-20 22:28, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sat, 20 Jan 2018 22:11:24 +0100
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Acked-by: Martin Kepplinger <martink@...teo.de>

> ---
>  drivers/input/touchscreen/sur40.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c
> index f16f8358c70a..c7a0a92b2044 100644
> --- a/drivers/input/touchscreen/sur40.c
> +++ b/drivers/input/touchscreen/sur40.c
> @@ -591,7 +591,6 @@ static int sur40_probe(struct usb_interface *interface,
>  	sur40->bulk_in_epaddr = endpoint->bEndpointAddress;
>  	sur40->bulk_in_buffer = kmalloc(sur40->bulk_in_size, GFP_KERNEL);
>  	if (!sur40->bulk_in_buffer) {
> -		dev_err(&interface->dev, "Unable to allocate input buffer.");
>  		error = -ENOMEM;
>  		goto err_free_polldev;
>  	}
>