linux-kernel - Re: [PATCH 2/2] Input: sur40: Improve a size determination in sur40

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8b3fb313-b69d-f381-dde8-212a85b5a90e@posteo.de>
Date:   Mon, 22 Jan 2018 08:02:52 +0100
From:   Martin Kepplinger <martink@...teo.de>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        linux-input@...r.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Florian Echtler <floe@...terbrot.org>,
        Johan Hovold <johan@...nel.org>,
        Martin Kaltenbrunner <modin@...i.at>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/2] Input: sur40: Improve a size determination in
 sur40_probe()

On 2018-01-20 22:30, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sat, 20 Jan 2018 22:16:14 +0100
> 
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Acked-by: Martin Kepplinger <martink@...teo.de>

> ---
>  drivers/input/touchscreen/sur40.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c
> index c7a0a92b2044..946e1a0328b4 100644
> --- a/drivers/input/touchscreen/sur40.c
> +++ b/drivers/input/touchscreen/sur40.c
> @@ -550,7 +550,7 @@ static int sur40_probe(struct usb_interface *interface,
>  		return -ENODEV;
>  
>  	/* Allocate memory for our device state and initialize it. */
> -	sur40 = kzalloc(sizeof(struct sur40_state), GFP_KERNEL);
> +	sur40 = kzalloc(sizeof(*sur40), GFP_KERNEL);
>  	if (!sur40)
>  		return -ENOMEM;
>  
>