linux-kernel - Re: [PATCH v4 1/2] nvme: add tracepoint for nvme_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180122161027.GA7097@lst.de>
Date:   Mon, 22 Jan 2018 17:10:27 +0100
From:   Christoph Hellwig <hch@....de>
To:     Johannes Thumshirn <jthumshirn@...e.de>
Cc:     Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
        Linux NVMe Mailinglist <linux-nvme@...ts.infradead.org>,
        Keith Busch <keith.busch@...el.com>,
        Hannes Reinecke <hare@...e.de>
Subject: Re: [PATCH v4 1/2] nvme: add tracepoint for nvme_setup_cmd

On Mon, Jan 22, 2018 at 05:04:37PM +0100, Johannes Thumshirn wrote:
> You mean like:
> 	if (ns)
> 		trace_nvme_setup_cmd(cmd);
> 	else
> 		trace_nvme_setup_admin_cmd(cmd);
> 
> ?

Yes.  Although I'd rename trace_nvme_setup_cmd to trace_nvme_setup_nvm_cmd
to prepare for new I/O command sets.