linux-kernel - Re: [PATCH] Input: stmfts,s6sy671

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180123014111.qt76xd7dnjikpmm7@dtor-ws>
Date:   Mon, 22 Jan 2018 17:41:11 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Andi Shyti <andi.shyti@...sung.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andi Shyti <andi@...zian.org>,
        Philippe Ombredanne <pombredanne@...b.com>
Subject: Re: [PATCH] Input: stmfts,s6sy671 - add SPDX identifier

On Tue, Jan 09, 2018 at 02:23:31PM +0900, Andi Shyti wrote:
> Hi Dmitry,
> 
> On Fri, Jan 05, 2018 at 08:49:58AM -0800, Dmitry Torokhov wrote:
> > Hi Andi,
> > 
> > On Fri, Jan 05, 2018 at 06:57:15PM +0900, Andi Shyti wrote:
> > > Hi Dmitry,
> > > 
> > > this is a kind ping, would you also mind giving me a feedback to
> > 
> > Yes, sorry. Could you please split the patch for each driver
> > individually? Also, until we have an update to the CodingStyle doc
> > mandating the C++ style comments, I'd prefer keeping the original style
> > of comments. So // for the SPDX line and /* */ for the rest.
> 
> I was actually following Linus guideline [1] [2]. I also had the
> same discussion previously in another context [3].
> 
> Please let me know if you still want a mixed style of comments in
> the next patch.

Eh, I guess it does not matter in the grand scheme of things; applied as
is.

Thank you.

> 
> Thanks,
> Andi
> 
> [1] https://marc.info/?l=linux-kernel&m=151163713125320&w=2
>     ...
>     └-> https://marc.info/?l=linux-kernel&m=151163867325641&w=2
>         ...
>         └-> https://marc.info/?l=linux-kernel&m=151163867325641&w=2
> 
> [2] https://marc.info/?l=linux-kernel&m=150964359922353
> [3] https://marc.info/?l=linux-kernel&m=151312974503109&w=2

-- 
Dmitry