linux-kernel - Re: [PATCH 1/5] USB: serial: f81232: clear overrun flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42995e53-a110-a0fa-da47-4ebe35272812@gmail.com>
Date:   Tue, 23 Jan 2018 09:50:48 +0800
From:   "Ji-Ze Hong (Peter Hong)" <hpeter@...il.com>
To:     Oliver Neukum <oneukum@...e.com>, johan@...nel.org
Cc:     peter_hong@...tek.com.tw,
        "Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@...il.com>,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH 1/5] USB: serial: f81232: clear overrun flag

Hi Oliver,

Oliver Neukum 於 2018/1/22 下午 06:06 寫道:
>> +static void f81232_lsr_worker(struct work_struct *work)
>> +{
>> +	struct f81232_private *priv;
>> +	struct usb_serial_port *port;
>> +	int status;
>> +	u8 tmp;
>> +
>> +	priv = container_of(work, struct f81232_private, lsr_work);
>> +	port = priv->port;
>> +
>> +	status = f81232_get_register(port, LINE_STATUS_REGISTER, &tmp);
>> +	if (status)
>> +		dev_warn(&port->dev, "read LSR failed: %d\n", status);
>> +}
> 
> Hi,
> 
> I am afraid this is incomplete. You are scheduling a work that does IO.
> Hence you must cancel that work when the driver is unbound from the
> interface. You must also not do IO like this while the system is suspending.

We'll add cancel worker operation on close() and suspend() to prevent
from I/O operations in wrong time with next patch version.

Thanks
-- 
With Best Regards,
Peter Hong