linux-kernel - Re: [PATCH 2/5] USB: serial: f81232: add high baud rate support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d8c1ff5-06fa-28f3-c5e8-3211497a6b17@gmail.com>
Date:   Tue, 23 Jan 2018 10:08:24 +0800
From:   "Ji-Ze Hong (Peter Hong)" <hpeter@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Johan Hovold <johan@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        USB <linux-usb@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Peter H <peter_hong@...tek.com.tw>,
        "Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@...il.com>
Subject: Re: [PATCH 2/5] USB: serial: f81232: add high baud rate support

Hi Andy,

Andy Shevchenko 於 2018/1/22 下午 10:55 寫道:
> On Mon, Jan 22, 2018 at 9:58 AM, Ji-Ze Hong (Peter Hong)
> <hpeter@...il.com> wrote:
>> The F81232 had 4 clocksource 1.846/18.46/14.77/24MHz and baud rates
>> can be up to 1.5Mbits with 24MHz.
>>
>> F81232 Clock registers (106h)
>>
>> Bit1-0:     Clock source selector
>>                      00: 1.846MHz.
>>                      01: 18.46MHz.
>>                      10: 24MHz.
>>                      11: 14.77MHz.
> 
> Hmm... Why not to provide a proper clk driver (based on table variant
> of clk-divider) and use it here?
> 
> 

It seems too complex to use clock framework in this driver.
What do you think about this, Johan ?

Thanks
-- 
With Best Regards,
Peter Hong