linux-kernel - Re: [PATCH v2] bsg: use pr_debug instead of hand craftet macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1516749137.3339.62.camel@wdc.com>
Date:   Tue, 23 Jan 2018 23:12:20 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "joe@...ches.com" <joe@...ches.com>,
        "jthumshirn@...e.de" <jthumshirn@...e.de>,
        "axboe@...com" <axboe@...com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>
Subject: Re: [PATCH v2] bsg: use pr_debug instead of hand craftet macros

On Tue, 2018-01-23 at 04:45 -0800, Joe Perches wrote:
> Perhaps the email subject could be improved to describe
> the new macro and as well, this macro, without a pr_fmt
> define somewhat above it loses the __func__ output too.

Hmm ... I thought that the pr_debug() output can be configured to include
the function name (__func__)? From
https://www.kernel.org/doc/html/latest/admin-guide/dynamic-debug-howto.html:

The flags are:

p    enables the pr_debug() callsite.
f    Include the function name in the printed message
l    Include line number in the printed message
m    Include module name in the printed message
t    Include thread ID in messages not generated from interrupt context
_    No flags are set. (Or'd with others on input)

Bart.