linux-kernel - Re: [RESEND PATCH 3/6] ARM: dts: imx7s: add CAAM device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b3c415f-64e4-1fcf-45ef-c447d65e8e89@nexus-software.ie>
Date:   Wed, 24 Jan 2018 22:48:20 +0000
From:   Bryan O'Donoghue <pure.logic@...us-software.ie>
To:     "Auer, Lukas" <lukas.auer@...ec.fraunhofer.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "aymen.sghaier@....com" <aymen.sghaier@....com>,
        "horia.geanta@....com" <horia.geanta@....com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>
Cc:     "peng.fan@....com" <peng.fan@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "ryan.harkin@...aro.org" <ryan.harkin@...aro.org>,
        "fabio.estevam@....com" <fabio.estevam@....com>,
        "rui.silva@...aro.org" <rui.silva@...aro.org>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>
Subject: Re: [RESEND PATCH 3/6] ARM: dts: imx7s: add CAAM device node

On 24/01/18 18:12, Auer, Lukas wrote:
> On Wed, 2018-01-24 at 14:50 +0000, Bryan O'Donoghue wrote:
>> From: Rui Miguel Silva <rui.silva@...aro.org>
>>
>> Add CAAM device node to the i.MX7s device tree.
>>
>> Signed-off-by: Rui Miguel Silva <rui.silva@...aro.org>
>> Cc: "Horia Geantă" <horia.geanta@....com>
>> Cc: Aymen Sghaier <aymen.sghaier@....com>
>> Cc: Fabio Estevam <fabio.estevam@....com>
>> Cc: Peng Fan <peng.fan@....com>
>> Cc: Herbert Xu <herbert@...dor.apana.org.au>
>> Cc: "David S. Miller" <davem@...emloft.net>
>> Cc: Lukas Auer <lukas.auer@...ec.fraunhofer.de>
>> Signed-off-by: Bryan O'Donoghue <pure.logic@...us-software.ie>
>> ---
>>   arch/arm/boot/dts/imx7s.dtsi | 26 ++++++++++++++++++++++++++
>>   1 file changed, 26 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx7s.dtsi
>> b/arch/arm/boot/dts/imx7s.dtsi
>> index 82ad26e..0da146e 100644
>> --- a/arch/arm/boot/dts/imx7s.dtsi
>> +++ b/arch/arm/boot/dts/imx7s.dtsi
>> @@ -805,6 +805,32 @@
>>   				status = "disabled";
>>   			};
>>   
>> +			crypto: caam@...00000 {
>> +				compatible = "fsl,sec-v4.0";
>> +				fsl,sec-era = <4>;
>> +				#address-cells = <1>;
>> +				#size-cells = <1>;
>> +				reg = <0x30900000 0x10000>;
>> +				ranges = <0 0x30900000 0x10000>;
>> +				clocks = <&clks IMX7D_CAAM_MEM_CLK>,
>> +					 <&clks
>> IMX7D_CAAM_ACLK_CLK>,
>> +					 <&clks IMX7D_CAAM_IPG_CLK>,
>> +					 <&clks IMX7D_EIM_ROOT_CLK>;
>> +				clock-names = "mem", "aclk", "ipg",
>> "emi_slow";
>> +
>> +				sec_jr0: jr0@...0 {
>> +					compatible = "fsl,sec-v4.0-
>> job-ring";
>> +					reg = <0x1000 0x1000>;
>> +					interrupts = <GIC_SPI 105
>> IRQ_TYPE_LEVEL_HIGH>;
>> +				};
>> +
>> +				sec_jr1: jr1@...0 {
>> +					compatible = "fsl,sec-v4.0-
>> job-ring";
>> +					reg = <0x2000 0x1000>;
>> +					interrupts = <GIC_SPI 106
>> IRQ_TYPE_LEVEL_HIGH>;
>> +				};
>> +			};
>> +
>>   			flexcan1: can@...00000 {
>>   				compatible = "fsl,imx7d-flexcan",
>> "fsl,imx6q-flexcan";
>>   				reg = <0x30a00000 0x10000>;
> 
> Looking at the device tree from the NXP kernel [1], the job ring and
> clock configurations should be slightly different.
> 
> The job ring configuration has one additional job ring at offset 3000
> and interrupt 114.

Yes true, that should be added.

We will do that in v2, thanks for spotting.

> The clock configuration has changed to just one CAAM-specific clock in
> addition to the ahb clock. This also means that additional
> modifications to the CAAM driver are necessary or it will complain that
> it doesn't find all clocks.

Sure - but, those clock changes aren't merged to upstream just yet, so 
we won't those changes to this DTS addition yet.

Thanks for the review.

---
bod