linux-kernel - Re: [RESEND PATCH 3/6] ARM: dts: imx7s: add CAAM device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08d9947e-4d2b-61f1-c8ed-0e1350025f76@nexus-software.ie>
Date:   Wed, 24 Jan 2018 22:56:45 +0000
From:   Bryan O'Donoghue <pure.logic@...us-software.ie>
To:     "Auer, Lukas" <lukas.auer@...ec.fraunhofer.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "aymen.sghaier@....com" <aymen.sghaier@....com>,
        "horia.geanta@....com" <horia.geanta@....com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>
Cc:     "peng.fan@....com" <peng.fan@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "ryan.harkin@...aro.org" <ryan.harkin@...aro.org>,
        "fabio.estevam@....com" <fabio.estevam@....com>,
        "rui.silva@...aro.org" <rui.silva@...aro.org>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>
Subject: Re: [RESEND PATCH 3/6] ARM: dts: imx7s: add CAAM device node

On 24/01/18 22:48, Bryan O'Donoghue wrote:
>> The clock configuration has changed to just one CAAM-specific clock in
>> addition to the ahb clock. This also means that additional
>> modifications to the CAAM driver are necessary or it will complain that
>> it doesn't find all clocks.
> 
> Sure - but, those clock changes aren't merged to upstream just yet, so 
> we won't those changes to this DTS addition yet.
> 
> Thanks for the review.
> 
> ---
> bod

Ah Rui has pointed out to me for i.mx7 there are two clocks on on i.mx6 
there are four clocks.

The bit that confused me there was the clock names on the 4.1 tree you 
pointed to was clock-names = "caam_ipg", "caam_aclk"; and for 4.15 those 
should be "ipg" and "aclk" by the looks of it.

So yes.

We will add the second job-ring and subtract the two extraneous clocks.

---
bod