linux-kernel - Re: [PATCH] phy: qcom-ufs: add MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 24 Jan 2018 14:55:28 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Vivek Gautam <vivek.gautam@...eaurora.org>,
        Subhash Jadavani <subhashj@...eaurora.org>,
        Heiko Stuebner <heiko@...ech.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] phy: qcom-ufs: add MODULE_LICENSE tag

On Wed 10 Jan 08:35 PST 2018, Arnd Bergmann wrote:

> While the specific UFS PHY drivers (14nm and 20nm) have a module
> license, the common base module does not, leading to a Kbuild
> failure:
> 
> WARNING: modpost: missing MODULE_LICENSE() in drivers/phy/qualcomm/phy-qcom-ufs.o
> FATAL: modpost: GPL-incompatible module phy-qcom-ufs.ko uses GPL-only symbol 'clk_enable'
> 
> This adds a module description and license tag to fix the build.
> I added both Yaniv and Vivek as authors here, as Yaniv sent the initial
> submission, while Vivek did most of the work since.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Regards,
Bjorn

> ---
>  drivers/phy/qualcomm/phy-qcom-ufs.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/phy/qualcomm/phy-qcom-ufs.c b/drivers/phy/qualcomm/phy-qcom-ufs.c
> index c5ff4525edef..c5493ea51282 100644
> --- a/drivers/phy/qualcomm/phy-qcom-ufs.c
> +++ b/drivers/phy/qualcomm/phy-qcom-ufs.c
> @@ -675,3 +675,8 @@ int ufs_qcom_phy_power_off(struct phy *generic_phy)
>  	return 0;
>  }
>  EXPORT_SYMBOL_GPL(ufs_qcom_phy_power_off);
> +
> +MODULE_AUTHOR("Yaniv Gardi <ygardi@...eaurora.org>");
> +MODULE_AUTHOR("Vivek Gautam <vivek.gautam@...eaurora.org>");
> +MODULE_DESCRIPTION("Universal Flash Storage (UFS) QCOM PHY");
> +MODULE_LICENSE("GPL v2");
> -- 
> 2.9.0
>