linux-kernel - Re: [RFC PATCH 1/2] x86/ibpb: Skip IBPB when we switch back to same user process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180125085820.GV2228@hirez.programming.kicks-ass.net>
Date:   Thu, 25 Jan 2018 09:58:20 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Tim Chen <tim.c.chen@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org,
        KarimAllah Ahmed <karahmed@...zon.de>,
        Andi Kleen <ak@...ux.intel.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Andy Lutomirski <luto@...nel.org>,
        Arjan van de Ven <arjan@...ux.intel.com>,
        Ashok Raj <ashok.raj@...el.com>,
        Asit Mallick <asit.k.mallick@...el.com>,
        Borislav Petkov <bp@...e.de>,
        Dan Williams <dan.j.williams@...el.com>,
        Dave Hansen <dave.hansen@...el.com>,
        David Woodhouse <dwmw@...zon.co.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "H . Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
        Janakarajan Natarajan <Janakarajan.Natarajan@....com>,
        Joerg Roedel <joro@...tes.org>,
        Jun Nakajima <jun.nakajima@...el.com>,
        Laura Abbott <labbott@...hat.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Paolo Bonzini <pbonzini@...hat.com>, rkrcmar@...hat.com,
        Thomas Gleixner <tglx@...utronix.de>,
        Tom Lendacky <thomas.lendacky@....com>, x86@...nel.org
Subject: Re: [RFC PATCH 1/2] x86/ibpb: Skip IBPB when we switch back to same
 user process

On Wed, Jan 24, 2018 at 04:36:41PM -0800, Tim Chen wrote:
> These two patches provide optimization to skip IBPB for this
> commonly encountered scenario:
> We could switch to a kernel idle thread and then back to the original
> process such as:
> process A -> idle -> process A
> 
> In such scenario, we do not have to do IBPB here even though the process
> is non-dumpable, as we are switching back to the same process after
> an hiatus.
> 
> The cost is to have an extra pointer to track the last mm we were using before
> switching to the init_mm used by idle.  But avoiding the extra IBPB
> is probably worth the extra memory for such a common scenario.

So we already track active_mm for kernel threads. I can't immediately
see where this fails for idle and your changelog doesn't say.

> @@ -229,15 +230,17 @@ void switch_mm_irqs_off(struct mm_struct *prev, struct mm_struct *next,
>                   * As an optimization flush indirect branches only when
>                   * switching into processes that disable dumping.
>                   *
> -                 * This will not flush branches when switching into kernel
> -                 * threads, but it would flush them when switching to the
> -                 * idle thread and back.
> +		 * This will not flush branches when switching into kernel
> +		 * threads. It will also not flush if we switch to idle
> +		 * thread and back to the same process. It will flush if we
> +		 * switch to a different non-dumpable process.

Whitespace damage.

>                   *
>                   * It might be useful to have a one-off cache here
>                   * to also not flush the idle case, but we would need some
>                   * kind of stable sequence number to remember the previous mm.
>  		 */
> -		if (tsk && tsk->mm && get_dumpable(tsk->mm) != SUID_DUMP_USER)
> +		if (tsk && tsk->mm && (tsk->mm != last)
> +			&& get_dumpable(tsk->mm) != SUID_DUMP_USER)

Broken coding style, operators go at the end of the previous line.

>  			indirect_branch_prediction_barrier();
>  
>  		if (IS_ENABLED(CONFIG_VMAP_STACK)) {