linux-kernel - Re: [patch v11 11/12] platform/mellanox: mlxreg-hotplug: Add check for negative adapter number value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180125221639.GE24122@fury>
Date:   Thu, 25 Jan 2018 14:16:39 -0800
From:   Darren Hart <dvhart@...radead.org>
To:     Vadim Pasternak <vadimp@...lanox.com>
Cc:     andy.shevchenko@...il.com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        jiri@...nulli.us
Subject: Re: [patch v11 11/12] platform/mellanox: mlxreg-hotplug: Add check
 for negative adapter number value

On Wed, Jan 24, 2018 at 08:34:57PM +0000, Vadim Pasternak wrote:
> Verify before creation of hotplug device if the associated adapter number
> is negative. It could be in case hotplug event is not associated with
> hotplug device.
> 
> Signed-off-by: Vadim Pasternak <vadimp@...lanox.com>
> ---
>  drivers/platform/mellanox/mlxreg-hotplug.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c
> index b891ec7..c806451 100644
> --- a/drivers/platform/mellanox/mlxreg-hotplug.c
> +++ b/drivers/platform/mellanox/mlxreg-hotplug.c
> @@ -95,6 +95,14 @@ struct mlxreg_hotplug_priv_data {
>  
>  static int mlxreg_hotplug_device_create(struct mlxreg_core_data *data)
>  {
> +	/*
> +	 * Return if adapter number is negative. Return if adapter number is
> +	 * negative. It could be in case hotplug event is not associated with

First sentence repeated twice. I've corrected this.

-- 
Darren Hart
VMware Open Source Technology Center