linux-kernel - Re: [patch v11 10/12] platform/x86: mlx-platform: Extend register map configuration with IO access verification callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180125221601.GD24122@fury>
Date:   Thu, 25 Jan 2018 14:16:01 -0800
From:   Darren Hart <dvhart@...radead.org>
To:     Vadim Pasternak <vadimp@...lanox.com>
Cc:     andy.shevchenko@...il.com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        jiri@...nulli.us
Subject: Re: [patch v11 10/12] platform/x86: mlx-platform: Extend register
 map configuration with IO access verification callbacks

On Wed, Jan 24, 2018 at 08:34:56PM +0000, Vadim Pasternak wrote:
> Add definitions for hotplug device masks and events offsets.
> 
> Extend register map configuration with the sets of writable, readable and
> volatile registers to allow verification prior to the access.
> 
> Extend register map configuration with cache type field: use flat type.

This says "what" you're doing, but not why. The point of the change log is to
help the reviewer or some future debugger to understand not WHAT you did (we
have that in the code below) but WHY you did it - keeping in mind that we likely
haven't spent the time you have to understand what the right thing is to do
here, so share with us the result of your research.

"Extend register map configuration with cache type field: use flat type, in
order to XXXXXXXXXX".

Please keep in mind for future patches.

...

> +
>  static int
>  mlxplat_mlxcpld_reg_read(void *context, unsigned int reg, unsigned int *val)
>  {
> @@ -317,6 +384,10 @@ static const struct regmap_config mlxplat_mlxcpld_regmap_config = {
>  	.reg_bits = 8,
>  	.val_bits = 8,
>  	.max_register = 255,
> +	.cache_type = REGCACHE_FLAT,

-- 
Darren Hart
VMware Open Source Technology Center