linux-kernel - Re: [patch v11 09/12] platform/x86: mlx-platform: Simplify IO access to regmap context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180125221332.GC24122@fury>
Date:   Thu, 25 Jan 2018 14:13:32 -0800
From:   Darren Hart <dvhart@...radead.org>
To:     Vadim Pasternak <vadimp@...lanox.com>
Cc:     andy.shevchenko@...il.com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        jiri@...nulli.us
Subject: Re: [patch v11 09/12] platform/x86: mlx-platform: Simplify IO access
 to regmap context

On Wed, Jan 24, 2018 at 08:34:55PM +0000, Vadim Pasternak wrote:
> Get rid of struct mlxplat_mlxcpld_regmap_context, which contains only the
> field with base address. Instead obtain base memory address by
> devm_ioport_map  to local variable and pass it to devm_regmap_init.
> 
> Modify mlxplat_mlxcpld_reg_read/write to directly use pointer to context
> for IO operations.
> 
> Add missed description of pdev_hotplug for struct mlxplat_priv.

Separate patch. Keep in mind that if there is a bug, and a patch is reverted -
do you want it all reverted together? In this case, the comment is totally
unrelated to this change. I've made this change.

-- 
Darren Hart
VMware Open Source Technology Center