linux-kernel - Re: [PATCH] Bluetooth: btintel: remove extraneous semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <EBF0FA29-819E-4419-84D1-9CE22E8AE0A5@holtmann.org>
Date:   Fri, 26 Jan 2018 16:22:39 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Tedd Ho-Jeong An <tedd.an@...ux.intel.com>,
        Bluez mailing list <linux-bluetooth@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: btintel: remove extraneous semicolon

Hi Arnd,

> The newly added btintel_download_firmware() dummy helper definition is
> incorrect, causing a build error when CONFIG_BT_INTEL is disabled:
> 
> In file included from drivers/bluetooth/hci_ldisc.c:49:0:
> drivers/bluetooth/btintel.h:196:1: error: expected identifier or '(' before '{' token
> drivers/bluetooth/btintel.h:193:19: error: 'btintel_download_firmware' declared 'static' but never defined [-Werror=unused-function]
> 
> Removing the semicolon makes it work again.
> 
> Fixes: 0bd4ded3287d ("Bluetooth: btintel: Create common function for firmware download")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> drivers/bluetooth/btintel.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/btintel.h b/drivers/bluetooth/btintel.h
> index 01728e212267..41c642cc523f 100644
> --- a/drivers/bluetooth/btintel.h
> +++ b/drivers/bluetooth/btintel.h
> @@ -192,7 +192,7 @@ static inline int btintel_read_boot_params(struct hci_dev *hdev,
> 
> static inline int btintel_download_firmware(struct hci_dev *dev,
> 					    const struct firmware *fw,
> -					    u32 *boot_param);
> +					    u32 *boot_param)
> {
> 	return -EOPNOTSUPP;
> }

didn’t I fix this before sending the pull request? Can you check against net-next tree that this is still an issue?

Regards

Marcel