linux-kernel - Re: [PATCH] ARM: dts: imx25-pinfunc: Always set SION for SD CMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5Dfrj9H4t6T2NJH3BQ49yAx3k3a=5HRFcR+Ce5dneBfKg@mail.gmail.com>
Date:   Fri, 26 Jan 2018 22:28:30 -0200
From:   Fabio Estevam <festevam@...il.com>
To:     Benoît Thébaudeau 
        <benoit.thebaudeau.dev@...il.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        Russell King <linux@...linux.org.uk>,
        Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Fabio Estevam <fabio.estevam@....com>,
        Sascha Hauer <kernel@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Michael Nazzareno Trimarchi <michael@...rulasolutions.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH] ARM: dts: imx25-pinfunc: Always set SION for SD CMD

On Fri, Jan 26, 2018 at 10:07 PM, Benoît Thébaudeau
<benoit.thebaudeau.dev@...il.com> wrote:
> The eSDHC does not work properly if the SION bit is not set for the
> bidirectional CMD signal, whatever the eSDHC instance and the selected
> pad. Therefore, setting SION is mandatory for all eSDHC CMD ports. Do
> this for MX25_PAD_*__SD*_CMD in imx25-pinfunc.h in order to enforce this
> behavior for all boards.
>
> This had already been done for eSDHC1, but not for eSDHC2. Also, define
> MX25_PAD_FEC_MDC__SDHC2_CMD so that all the possible cases are covered
> from now on.
>
> Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau.dev@...il.com>

Thanks for the fix:

Reviewed-by: Fabio Estevam <fabio.estevam@....com>