linux-kernel - Re: [0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe3d92c5-8e51-ea72-7637-6545c1654dd3@users.sourceforge.net>
Date:   Mon, 29 Jan 2018 10:31:04 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Devesh Sharma <devesh.sharma@...adcom.com>,
        linux-rdma <linux-rdma@...r.kernel.org>
Cc:     Doug Ledford <dledford@...hat.com>, Jason Gunthorpe <jgg@...pe.ca>,
        Selvin Xavier <selvin.xavier@...adcom.com>,
        Somnath Kotur <somnath.kotur@...adcom.com>,
        Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Himanshu Jha <himanshujha199640@...il.com>
Subject: Re: [0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

> You don't need 2 patches when changing same lines of code.

Are these really the same?


> Could you squash both and send your changes in a single patch.

I prefer to keep the deletion of questionable error messages separate
from the refactoring for a bit of exception handling.


> The patches look good to me otherwise.

Thanks for your constructive feedback.

Regards,
Markus