linux-kernel - Re: [PATCH v2] dmaengine: dmatest: fix container_of member in dmatest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ca31eff-f566-aefe-1364-b488f49117ed@codeaurora.org>
Date:   Mon, 29 Jan 2018 08:17:26 -0500
From:   Adam Wallis <awallis@...eaurora.org>
To:     Yang Shunyong <shunyong.yang@...-semitech.com>,
        vinod.koul@...el.com
Cc:     dan.j.williams@...el.com, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org, yu.zheng@...-semitch.com
Subject: Re: [PATCH v2] dmaengine: dmatest: fix container_of member in
 dmatest_callback

Yang,

On 1/29/2018 1:40 AM, Yang Shunyong wrote:
> The type of arg passed to dmatest_callback is struct dmatest_done.
> It refers to test_done in struct dmatest_thread, not done_wait.
> 
> Fixes: 6f6a23a213be ("dmaengine: dmatest: move callback wait ...")
> Signed-off-by: Yang Shunyong <shunyong.yang@...-semitech.com>
> Signed-off-by: Vinod Koul <vinod.koul@...el.com>
> ---
> 
> v2: change arg to done in container_of().
> 
> ---
>  drivers/dma/dmatest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> index ec5f9d2bc820..80cc2be6483c 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)
>  {
>  	struct dmatest_done *done = arg;
>  	struct dmatest_thread *thread =
> -		container_of(arg, struct dmatest_thread, done_wait);
> +		container_of(done, struct dmatest_thread, test_done);
>  	if (!thread->done) {
>  		done->done = true;
>  		wake_up_all(done->wait);
> 

Thanks again for the fix (and to Vinod for the cleanup)

Acked-by: Adam Wallis <awallis@...eaurora.org>

-- 
Adam Wallis
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.