linux-kernel - Re: [PATCH] ASoC: codecs: Add support for AK5558 ADC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfmP2zYycht01fo-RPh9o=tRSk4RS6UW02XBjsn7mKgFQ@mail.gmail.com>
Date:   Wed, 31 Jan 2018 18:56:43 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     Daniel Baluta <daniel.baluta@....com>,
        Mark Brown <broonie@...nel.org>,
        ALSA Development Mailing List <alsa-devel@...a-project.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        wakasugi.jb@...asahi-kasei.co.jp, shengjiu.wang@....com,
        mihai.serban@...il.com, cosmin.samoila@....com, linux-imx@....com,
        Mihai Serban <mihai.serban@....com>
Subject: Re: [PATCH] ASoC: codecs: Add support for AK5558 ADC driver

On Wed, Jan 31, 2018 at 6:20 PM, Fabio Estevam <festevam@...il.com> wrote:
> Hi Daniel,

Fabio, +1 to your review. It seems it repeats some of the points I made.


>> +       ak5558->pdn_gpio = of_get_named_gpio(np, "ak5558,pdn-gpio", 0);
>
> It does not match the property in the binding doc: asahi-kasei,pdn-gpios

Btw, it must be simple "reset" as a widely used for the same purpose.

-- 
With Best Regards,
Andy Shevchenko