linux-kernel - Re: [tip:irq/urgent] genirq: Make legacy autoprobing work again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1802011055240.1472@nanos.tec.linutronix.de>
Date:   Thu, 1 Feb 2018 10:56:13 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "H. Peter Anvin" <hpa@...or.com>, Meelis Roos <mroos@...ux.ee>,
        Ingo Molnar <mingo@...nel.org>,
        linux-tip-commits@...r.kernel.org,
        kbuild test robot <fengguang.wu@...el.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [tip:irq/urgent] genirq: Make legacy autoprobing work again

On Thu, 1 Feb 2018, Geert Uytterhoeven wrote:
> On Wed, Jan 31, 2018 at 10:54 AM, tip-bot for Thomas Gleixner
> > -void irq_activate_and_startup(struct irq_desc *desc, bool resend)
> > +int irq_activate_and_startup(struct irq_desc *desc, bool resend)
> >  {
> >         if (WARN_ON(irq_activate(desc)))
> >                 return;
> 
> As reported by 0day, this should return something.
> 
> if CONFIG_IRQ_DOMAIN=n or CONFIG_IRQ_DOMAIN_HIERARCHY=n,
> irq_activate() will never return 1, and the code path can be eliminated.
> 
> BTW, is gcc becoming too smart, and already eliminating code before it
> generates warnings for it? Recently I've seen some other cases where buggy
> code was not warned about, as it was considered not having any impact.

Looks like. Fixed it up.

Thanks,

	tglx