linux-kernel - Re: [PATCH v5 1/5] pwm-backlight: enable/disable the PWM before/after LCD enable toggle.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 1 Feb 2018 12:06:43 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Enric Balletbo Serra <eballetbo@...il.com>
Cc:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Jingoo Han <jingoohan1@...il.com>,
        Rob Herring <robh+dt@...nel.org>, Pavel Machek <pavel@....cz>,
        Heiko Stuebner <heiko@...ech.de>,
        Thierry Reding <thierry.reding@...il.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Richard Purdie <rpurdie@...ys.net>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Linux PWM List <linux-pwm@...r.kernel.org>,
        linux-fbdev@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Guenter Roeck <groeck@...omium.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>
Subject: Re: [PATCH v5 1/5] pwm-backlight: enable/disable the PWM
 before/after LCD enable toggle.

On Tue, 30 Jan 2018, Enric Balletbo Serra wrote:

> Hi,
> 
> 2017-12-01 13:06 GMT+01:00 Enric Balletbo i Serra <enric.balletbo@...labora.com>:
> > Before this patch the enable signal was set before the PWM signal and
> > vice-versa on power off. This sequence is wrong, at least, it is on
> > the different panels datasheets that I checked, so I inverted the sequence
> > to follow the specs.
> >
> > For reference the following panels have the mentioned sequence:
> >   - N133HSE-EA1 (Innolux)
> >   - N116BGE (Innolux)
> >   - N156BGE-L21 (Innolux)
> >   - B101EAN0 (Auo)
> >   - B101AW03 (Auo)
> >   - LTN101NT05 (Samsung)
> >   - CLAA101WA01A (Chunghwa)
> >
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> > Acked-by: Daniel Thompson <daniel.thompson@...aro.org>
> > Acked-by: Jingoo Han <jingoohan1@...il.com>
> > ---
> > Changes since v4:
> >  - Rebase on top of mainline.
> >  - Add the acks from Daniel Thompson and Jingoo Han.
> > Changes since v3:
> >  - List the part numbers for the panel checked (Daniel Thompson)
> > Changes since v2:
> >  - Add this as a separate patch (Thierry Reding)
> > Changes since v1:
> >  - None
> >
> >  drivers/video/backlight/pwm_bl.c | 9 +++++----
> >  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> A gentle ping, It's been nearly two months since I sent this patchset,
> there is anything else that prevents these patches to land or
> incorporate in linux-next?

Looks like Daniel should Ack 2/5 since he had comments on it before
and it still lacks a Backlight Ack.

With regards to -next, the merge-window is open (should close in a
little over a week), so the chances are, you'll get a long soak before
the next merge-window opens.

-- 
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog