linux-kernel - Re: [PATCH v11 03/10] sparc64: Add support for ADI register fields, ASIs and traps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1517517122.7489.47.camel@perches.com>
Date:   Thu, 01 Feb 2018 12:32:02 -0800
From:   Joe Perches <joe@...ches.com>
To:     Khalid Aziz <khalid.aziz@...cle.com>, davem@...emloft.net,
        dave.hansen@...ux.intel.com
Cc:     mhocko@...e.com, mingo@...nel.org, gregkh@...uxfoundation.org,
        glx@...utronix.de, kstewart@...uxfoundation.org,
        vijay.ac.kumar@...cle.com, kirill.shutemov@...ux.intel.com,
        nitin.m.gupta@...cle.com, tom.hromatka@...cle.com,
        allen.pais@...cle.com, rob.gardner@...cle.com,
        david.j.aldridge@...cle.com, babu.moger@...cle.com,
        bob.picco@...cle.com, steven.sistare@...cle.com,
        pasha.tatashin@...cle.com, vegard.nossum@...cle.com,
        pombredanne@...b.com, jane.chu@...cle.com,
        anthony.yznaga@...cle.com, sparclinux@...r.kernel.org,
        linux-kernel@...r.kernel.org, Khalid Aziz <khalid@...ehiking.org>
Subject: Re: [PATCH v11 03/10] sparc64: Add support for ADI register fields,
 ASIs and traps

On Thu, 2018-02-01 at 11:01 -0700, Khalid Aziz wrote:
> diff --git a/arch/sparc/include/asm/pgtable_64.h b/arch/sparc/include/asm/pgtable_64.h
[]
> @@ -164,6 +164,8 @@ bool kern_addr_valid(unsigned long addr);
>  #define _PAGE_E_4V	  _AC(0x0000000000000800,UL) /* side-Effect          */
>  #define _PAGE_CP_4V	  _AC(0x0000000000000400,UL) /* Cacheable in P-Cache */
>  #define _PAGE_CV_4V	  _AC(0x0000000000000200,UL) /* Cacheable in V-Cache */
> +/* Bit 9 is used to enable MCD corruption detection instead on M7 */
> +#define _PAGE_MCD_4V      _AC(0x0000000000000200,UL) /* Memory Corruption    */

trivia:

There are some whitespace alignment issues here

> diff --git a/arch/sparc/include/asm/ttable.h b/arch/sparc/include/asm/ttable.h
[]
> @@ -219,6 +219,16 @@
>  	nop;						\
>  	nop;
>  
> +#define SUN4V_MCD_PRECISE				\
> +	ldxa	[%g0] ASI_SCRATCHPAD, %g2;		\
> +	ldx	[%g2 + HV_FAULT_D_ADDR_OFFSET], %g4;	\
> +	ldx	[%g2 + HV_FAULT_D_CTX_OFFSET], %g5;	\
> +	ba,pt	%xcc, etrap;				\
> +	 rd	%pc, %g7;				\
> +	ba,pt	%xcc, sun4v_mcd_detect_precise;		\
> +	 nop;						\
> +	nop;

and here and elsewhere.

It would be nicer to make all these use
similar indentation.

> diff --git a/arch/sparc/kernel/sun4v_mcd.S b/arch/sparc/kernel/sun4v_mcd.S
[]
> +sun4v_mcd_detect_precise:
> +	mov	%l4, %o1
> +	mov 	%l5, %o2
> +	call	sun4v_mem_corrupt_detect_precise
> +	 add	%sp, PTREGS_OFF, %o0
> +	ba,a,pt	%xcc, rtrap
> +	 nop

etc...