linux-kernel - Re: [PATCH v11 03/10] sparc64: Add support for ADI register fields, ASIs and traps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180201.153903.1719756519690647679.davem@davemloft.net>
Date:   Thu, 01 Feb 2018 15:39:03 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     joe@...ches.com
Cc:     khalid.aziz@...cle.com, dave.hansen@...ux.intel.com,
        mhocko@...e.com, mingo@...nel.org, gregkh@...uxfoundation.org,
        glx@...utronix.de, kstewart@...uxfoundation.org,
        vijay.ac.kumar@...cle.com, kirill.shutemov@...ux.intel.com,
        nitin.m.gupta@...cle.com, tom.hromatka@...cle.com,
        allen.pais@...cle.com, rob.gardner@...cle.com,
        david.j.aldridge@...cle.com, babu.moger@...cle.com,
        bob.picco@...cle.com, steven.sistare@...cle.com,
        pasha.tatashin@...cle.com, vegard.nossum@...cle.com,
        pombredanne@...b.com, jane.chu@...cle.com,
        anthony.yznaga@...cle.com, sparclinux@...r.kernel.org,
        linux-kernel@...r.kernel.org, khalid@...ehiking.org
Subject: Re: [PATCH v11 03/10] sparc64: Add support for ADI register
 fields, ASIs and traps

From: Joe Perches <joe@...ches.com>
Date: Thu, 01 Feb 2018 12:32:02 -0800

>> diff --git a/arch/sparc/include/asm/ttable.h b/arch/sparc/include/asm/ttable.h
> []
>> @@ -219,6 +219,16 @@
>>  	nop;						\
>>  	nop;
>>  
>> +#define SUN4V_MCD_PRECISE				\
>> +	ldxa	[%g0] ASI_SCRATCHPAD, %g2;		\
>> +	ldx	[%g2 + HV_FAULT_D_ADDR_OFFSET], %g4;	\
>> +	ldx	[%g2 + HV_FAULT_D_CTX_OFFSET], %g5;	\
>> +	ba,pt	%xcc, etrap;				\
>> +	 rd	%pc, %g7;				\
>> +	ba,pt	%xcc, sun4v_mcd_detect_precise;		\
>> +	 nop;						\
>> +	nop;
> 
> and here and elsewhere.

Joe, this is intentional in Sparc assembler.

Branches on sparc have delay slots, and this is annotated by indenting
the delay slot instruction one space more than the branch preceeding
it.

Please make more constructive review comments than whitespace as these
patches have been under review for more than half a year.

Thank you very much.