linux-kernel - Re: [PATCH v2 1/2] ASoC: codecs: Add support for AK5558 ADC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 3 Feb 2018 00:11:02 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Daniel Baluta <daniel.baluta@....com>,
        ALSA Development Mailing List <alsa-devel@...a-project.org>,
        devicetree <devicetree@...r.kernel.org>,
        Fabio Estevam <fabio.estevam@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        wakasugi.jb@...asahi-kasei.co.jp,
        "S.j. Wang" <shengjiu.wang@....com>,
        Mihai Serban <mihai.serban@...il.com>,
        Cosmin Samoila <cosmin.samoila@....com>,
        dl-linux-imx <linux-imx@....com>,
        Daniel Baluta <daniel.baluta@...il.com>,
        Mihai Serban <mihai.serban@....com>
Subject: Re: [PATCH v2 1/2] ASoC: codecs: Add support for AK5558 ADC driver

On Fri, Feb 02, 2018 at 09:33:18PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 2, 2018 at 6:20 PM, Daniel Baluta <daniel.baluta@....com> wrote:

> > +static int ak5558_set_dai_mute(struct snd_soc_dai *dai, int mute)
> > +{
> > +       struct snd_soc_codec *codec = dai->codec;
> > +       struct ak5558_priv *ak5558 = snd_soc_codec_get_drvdata(codec);
> 
> > +       int ndt = 0;
> 
> It might be even
> 
>       int ndt = max(ak5558->fs ? 583000 / ak5558->fs : 5, 5);

Please don't encourage people to use the ternery operator like that, it
does nothing for legibility not to write out the conditionals.

> > +static const struct i2c_device_id ak5558_i2c_id[] = {
> > +       { "ak5558", 0 },
> > +       { }
> > +};
> > +MODULE_DEVICE_TABLE(i2c, ak5558_i2c_id);

> I dunno if it's really helpful to have. Though it's up to Mark and you.

I don't care either way.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)