linux-kernel - Re: [PATCH] Add delay-init quirk for Corsair K70 RGB keyboards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <14038CE4-3754-426C-AC53-0AFE58D095A3@canonical.com>
Date:   Sun, 4 Feb 2018 21:35:42 +0800
From:   Kai Heng Feng <kai.heng.feng@...onical.com>
To:     JackStocker <jackstocker.93@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Seth Forshee <seth.forshee@...onical.com>,
        Stefan Bader <stefan.bader@...onical.com>,
        Samuel Thibault <samuel.thibault@...-lyon.org>,
        Devin Heitmueller <dheitmueller@...nellabs.com>,
        Sandeep Singh <sandeep.singh@....com>,
        Dmitry Fleytman <dmitry@...nix.com>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add delay-init quirk for Corsair K70 RGB keyboards



> On 2 Feb 2018, at 11:51 PM, JackStocker <jackstocker.93@...il.com> wrote:
> 
> From: Jack Stocker <jackstocker.93@...il.com>
> 
> Following on from this patch: https://lkml.org/lkml/2017/11/3/516,
> Corsair K70 RGB keyboards also require the DELAY_INIT quirk to
> start correctly at boot.
> 
> Device ids found here:
> usb 3-3: New USB device found, idVendor=1b1c, idProduct=1b13
> usb 3-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> usb 3-3: Product: Corsair K70 RGB Gaming Keyboard 
> 
> Signed-off-by: Jack Stocker <jackstocker.93@...il.com>
> ---
> drivers/usb/core/quirks.c | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index a6aaf2f..9eb92dc 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -221,6 +221,9 @@ static const struct usb_device_id usb_quirk_list[] = {
> 	/* Corsair Strafe RGB */
> 	{ USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT },
> 
> +	/* Corsair K70 RGB */
> +	{ USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
> +

I think this change should move up, to make the table follows an ascending order.

> 	/* MIDI keyboard WORLDE MINI */
> 	{ USB_DEVICE(0x1c75, 0x0204), .driver_info =
> 			USB_QUIRK_CONFIG_INTF_STRINGS },
> -- 
> 2.7.4
>