linux-kernel - Re: [PATCH 19/20] ARC: Fix malformed ARC_EMUL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e1dcff1-8bf6-39ce-9646-2441a78a3e34@synopsys.com>
Date:   Mon, 5 Feb 2018 09:17:53 -0800
From:   Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:     Ulf Magnusson <ulfalizer@...il.com>, <linux-kernel@...r.kernel.org>
CC:     <robh@...nel.org>, <linux-snps-arc@...ts.infradead.org>,
        <linux-kbuild@...r.kernel.org>, <tony@...mide.com>,
        <linus.walleij@...aro.org>, <sboyd@...eaurora.org>,
        <mina86@...a86.com>, <tfiga@...omium.org>, <paulus@...abs.org>,
        <yamada.masahiro@...ionext.com>, <paul.burton@...s.com>,
        <npiggin@...il.com>, <will.deacon@....com>, <egtvedt@...fundet.no>,
        <mgorman@...hsingularity.net>, <hch@....de>,
        <m.szyprowski@...sung.com>
Subject: Re: [PATCH 19/20] ARC: Fix malformed ARC_EMUL_UNALIGNED default

On 02/04/2018 05:21 PM, Ulf Magnusson wrote:
> 'default N' should be 'default n', though they happen to have the same
> effect here, due to undefined symbols (N in this case) evaluating to n
> in a tristate sense.
> 
> Remove the default from ARC_EMUL_UNALIGNED instead of changing it. bool
> and tristate symbols implicitly default to n.
> 
> Discovered with the
> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> script.
> 
> Signed-off-by: Ulf Magnusson <ulfalizer@...il.com>


Added to ARC for-curr.

Thx,
-Vineet

> ---
>   arch/arc/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig
> index f3a80cf164cc..d76bf4a83740 100644
> --- a/arch/arc/Kconfig
> +++ b/arch/arc/Kconfig
> @@ -484,7 +484,6 @@ config ARC_CURR_IN_REG
>   
>   config ARC_EMUL_UNALIGNED
>   	bool "Emulate unaligned memory access (userspace only)"
> -	default N
>   	select SYSCTL_ARCH_UNALIGN_NO_WARN
>   	select SYSCTL_ARCH_UNALIGN_ALLOW
>   	depends on ISA_ARCOMPACT
>