linux-kernel - Re: [PATCH 05/20] rtc: at32ap700x: Remove PLATFORM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Feb 2018 21:31:04 +0100
From:   Ulf Magnusson <ulfalizer@...il.com>
To:     Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        tfiga@...omium.org, paul.burton@...s.com,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Hans-Christian Noren Egtvedt <egtvedt@...fundet.no>,
        Linus Walleij <linus.walleij@...aro.org>, vgupta@...opsys.com,
        mgorman@...hsingularity.net, hch@....de, mina86@...a86.com,
        robh@...nel.org, sboyd@...eaurora.org,
        Paul Mackerras <paulus@...abs.org>, will.deacon@....com,
        Tony Lindgren <tony@...mide.com>,
        Nicholas Piggin <npiggin@...il.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-rtc@...r.kernel.org
Subject: Re: [PATCH 05/20] rtc: at32ap700x: Remove PLATFORM_AT32AP dependency

On Mon, Feb 5, 2018 at 3:01 PM, Alexandre Belloni
<alexandre.belloni@...e-electrons.com> wrote:
> Hi,
>
> On 05/02/2018 at 02:42:38 +0100, Ulf Magnusson wrote:
>> On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson <ulfalizer@...il.com> wrote:
>> > The PLATFORM_AT32AP symbol went away when AVR32 was removed in
>> > commit 26202873bb51 ("avr32: remove support for AVR32 architecture").
>> >
>> > Remove the RTC_DRV_AT32AP700X dependency from RTC_DRV_AT32AP700X.
>> >
>> > Discovered with the
>> > https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
>> > script.
>> >
>> > Signed-off-by: Ulf Magnusson <ulfalizer@...il.com>
>> > ---
>> >  drivers/rtc/Kconfig | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
>> > index b71cc7b5fbc9..1f5f3bd82ab6 100644
>> > --- a/drivers/rtc/Kconfig
>> > +++ b/drivers/rtc/Kconfig
>> > @@ -1404,7 +1404,7 @@ config RTC_DRV_PL031
>> >
>> >  config RTC_DRV_AT32AP700X
>> >         tristate "AT32AP700X series RTC"
>> > -       depends on PLATFORM_AT32AP || COMPILE_TEST
>> > +       depends on COMPILE_TEST
>> >         help
>> >           Driver for the internal RTC (Realtime Clock) on Atmel AVR32
>> >           AT32AP700x family processors.
>> > --
>> > 2.14.1
>> >
>>
>> RTC_DRV_AT32AP700X could probably be removed along with
>> ./drivers/rtc/rtc-at32ap700x.c as well.
>>
>
> Note that the driver is already removed in Linus' tree.
>
>
> --
> Alexandre Belloni, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> http://bootlin.com

That got rid of the config symbol too. This patch is moot then.

Cheers,
Ulf