linux-kernel - Re: [PATCH 07/20] riscv: Remove ARCH_WANT_OPTIONAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFkk2KQzCE5KrUvyvL0Va+KT0O4BvT3PQAT2ZP4u3SGYUWcp2g@mail.gmail.com>
Date:   Tue, 6 Feb 2018 00:38:51 +0100
From:   Ulf Magnusson <ulfalizer@...il.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-kbuild <linux-kbuild@...r.kernel.org>, tfiga@...omium.org,
        paul.burton@...s.com, Marek Szyprowski <m.szyprowski@...sung.com>,
        Hans-Christian Egtvedt <egtvedt@...fundet.no>,
        Vineet Gupta <vgupta@...opsys.com>,
        mgorman@...hsingularity.net, Christoph Hellwig <hch@....de>,
        mina86@...a86.com, Rob Herring <robh@...nel.org>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Paul Mackerras <paulus@...abs.org>,
        Will Deacon <will.deacon@....com>,
        ext Tony Lindgren <tony@...mide.com>,
        Nicholas Piggin <npiggin@...il.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Palmer Dabbelt <palmer@...ive.com>,
        Albert Ou <albert@...ive.com>, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 07/20] riscv: Remove ARCH_WANT_OPTIONAL_GPIOLIB select

On Tue, Feb 6, 2018 at 12:25 AM, Linus Walleij <linus.walleij@...aro.org> wrote:
> On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson <ulfalizer@...il.com> wrote:
>
>> The ARCH_WANT_OPTIONAL_GPIOLIB symbol was removed in commit 65053e1a7743
>> ("gpio: delete ARCH_[WANTS_OPTIONAL|REQUIRE]_GPIOLIB"). GPIOLIB should
>> just be selected explicitly if needed.
>>
>> Remove the ARCH_WANT_OPTIONAL_GPIOLIB select from RISCV.
>>
>> See commit 0145071b3314 ("x86: Do away with
>> ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") and commit da9a1c6767 ("arm64: do
>> away with ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") as well.
>>
>> Discovered with the
>> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
>> script.
>>
>> Signed-off-by: Ulf Magnusson <ulfalizer@...il.com>
>
> This should probaly be replaced with
> select GPIOLIB
>
> Yours,
> Linus Walleij

That'd make more sense if GPIOLIB is actually used. The select has
been a no-op since mid-2016 at least, but maybe something else selects
GPIOLIB.

Cheers,
Ulf