linux-kernel - Re: [PATCH] nvme-pci: Fix incorrect use of CMB size to calculate q

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180206150552.GD31110@localhost.localdomain>
Date:   Tue, 6 Feb 2018 08:05:52 -0700
From:   Keith Busch <keith.busch@...el.com>
To:     sbates@...thlin.com
Cc:     axboe@...com, hch@....de, sagi@...mberg.me,
        linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvme-pci: Fix incorrect use of CMB size to calculate
 q_depth

On Mon, Feb 05, 2018 at 03:32:23PM -0700, sbates@...thlin.com wrote:
>  
> -	if (dev->cmb && (dev->cmbsz & NVME_CMBSZ_SQS)) {
> +	if (dev->cmb && use_cmb_sqes && (dev->cmbsz & NVME_CMBSZ_SQS)) {

Is this a prep patch for something coming later? dev->cmb is already
NULL if use_cmb_sqes is false.