linux-kernel - Re: [PATCH] nvme-pci: Fix incorrect use of CMB size to calculate q

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6ECB1B8A-A08D-466D-BD04-297ED26738E8@raithlin.com>
Date:   Tue, 6 Feb 2018 15:56:21 +0000
From:   "Stephen  Bates" <sbates@...thlin.com>
To:     Keith Busch <keith.busch@...el.com>
CC:     "axboe@...com" <axboe@...com>, "hch@....de" <hch@....de>,
        "sagi@...mberg.me" <sagi@...mberg.me>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvme-pci: Fix incorrect use of CMB size to calculate
 q_depth


> On Feb 6, 2018, at 8:02 AM, Keith Busch <keith.busch@...el.com> wrote:
> 
>> On Mon, Feb 05, 2018 at 03:32:23PM -0700, sbates@...thlin.com wrote:
>> 
>> -    if (dev->cmb && (dev->cmbsz & NVME_CMBSZ_SQS)) {
>> +    if (dev->cmb && use_cmb_sqes && (dev->cmbsz & NVME_CMBSZ_SQS)) {
> 
> Is this a prep patch for something coming later? dev->cmb is already
> NULL if use_cmb_sqes is false.

Thanks Keith. 

Not sure how I missed this. I was working on OOT patches to enable WDS and RDS in the CMB. I *thought* I’d confirmed this patch was applicable to upstream. Looks like I did not do that correctly. 

Sorry for the churn. We can leave this patch out for now. Thanks for the prompt feedback everyone!

Stephen