linux-kernel - Re: [PATCH 10/20] lib/Kconfig: Remove leftover select of GENERIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Feb 2018 16:16:07 +0000
From:   Robin Murphy <robin.murphy@....com>
To:     Ulf Magnusson <ulfalizer@...il.com>, linux-kernel@...r.kernel.org
Cc:     linux-kbuild@...r.kernel.org, tfiga@...omium.org,
        paul.burton@...s.com, m.szyprowski@...sung.com,
        egtvedt@...fundet.no, linus.walleij@...aro.org,
        vgupta@...opsys.com, mgorman@...hsingularity.net, hch@....de,
        mina86@...a86.com, robh@...nel.org, sboyd@...eaurora.org,
        paulus@...abs.org, will.deacon@....com, tony@...mide.com,
        npiggin@...il.com, yamada.masahiro@...ionext.com,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Nick Terrell <terrelln@...com>,
        Dan Williams <dan.j.williams@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Matthew Wilcox <mawilcox@...rosoft.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Dave Airlie <airlied@...hat.com>, Jeremy Kerr <jk@...abs.org>,
        Bart Van Assche <bart.vanassche@....com>
Subject: Re: [PATCH 10/20] lib/Kconfig: Remove leftover select of GENERIC_IO

On 05/02/18 01:21, Ulf Magnusson wrote:
> GENERIC_IO was removed by commit 9de8da47742b ("kconfig: kill off
> GENERIC_IO option"), but HAS_IOMEM still selects it.
> 
> Remove the select of GENERIC_IO from HAS_IOMEM.
> 
> Discovered with the
> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> script.

Since I also stumbled over this and tried to fix it,

Acked-by: Robin Murphy <robin.murphy@....com>

> Signed-off-by: Ulf Magnusson <ulfalizer@...il.com>
> ---
>   lib/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/lib/Kconfig b/lib/Kconfig
> index e96089499371..8ce8bcad6eff 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -396,7 +396,6 @@ config ASSOCIATIVE_ARRAY
>   config HAS_IOMEM
>   	bool
>   	depends on !NO_IOMEM
> -	select GENERIC_IO
>   	default y
>   
>   config HAS_IOPORT_MAP
>